Be aware of what you are booking: these are student residences and designed for single occupancy. You get adequate space, with a window, and there are hotels in Edinburgh which will charge noticeably less for rooms with neither of those. You also get use of a shared kitchen and seating area. You don't get a TV in your room, nor a kettle; also no clothes hangers and no aircon. The bedlinen and towels were pristine, the surfaces and bathroom facilities were properly clean, but the floor could have stood 5 minutes' more cleaning. If dust and a stray hair bother you, maybe pay double and go for a hotel.
Location is perfect for city visitors, especially for the Old Town: 5 minutes' walk to Holyrood Palace, 5 more to the foot of Arthur's Seat.
The interior soundproofing seemed OK (or all my neighbours were mice) but there is traffic noise from outside.